Gemm Universal unit tests for MainloopIntelW8A8 API #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive unit test coverage for Intel GPU FP8 GEMM operations using the MainloopIntelW8A8 dispatch policy. The tests validate FP8→FP32 matrix multiplication kernels on Intel Xe XMX architecture across various workload scenarios.
Key changes:
- Added 14 unit tests covering LLM model configurations (LLaMA2-7B, Mistral-7B), parallelization strategies, and various matrix dimensions
- Introduced new
TestXeoverload accepting explicit batch parameter for batched GEMM operations - Integrated new test file into CMake build system
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gemm_universal_fp8_fp8_fp32_tensor_op_f32_xe_models.cpp | New test file with 14 test cases covering model-specific and edge-case GEMM configurations |
| gemm_testbed_3x.hpp | Added TestXe overload with explicit batch size parameter and enhanced error reporting |
| CMakeLists.txt | Added new test file to SYCL-enabled build targets |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rolandschulz
approved these changes
Oct 17, 2025
Antonyvance
added
the
Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests for MainloopIntelW8A8 FP8 GEMM operations on Intel Xe
Comprehensive test coverage for Intel GPU FP8 GEMM kernels including:
Tests validate
MainloopIntelW8A8dispatch policy with FP8→FP32 precision on Intel Xe XMX architecture.